Fixed week of week based year handling#3299
Merged
penghuo merged 1 commit intoopensearch-project:mainfrom Feb 5, 2025
Merged
Conversation
Signed-off-by: Norman Jordan <norman.jordan@improving.com>
normanj-bitquill
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
seankao-az and
ykmr1224
as code owners
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-3299-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7d9f6bdeb8e74832065b2db03e5ded98585241eb
# Push it to GitHub
git push --set-upstream origin backport/backport-3299-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.xThen, create a pull request where the |
normanj-bitquill
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Feb 5, 2025
Signed-off-by: Norman Jordan <norman.jordan@improving.com> (cherry picked from commit 7d9f6bd)
acarbonetto
pushed a commit
that referenced
this pull request
Feb 5, 2025
7 tasks
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
Signed-off-by: Norman Jordan <norman.jordan@improving.com> Signed-off-by: xinyual <xinyual@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated
wformatting for dates to use ISO-8601 behaviour.Issue:
extract(week from <date>)returns the number of weeks in the year based on the DateTimeFormatter which uses 'en' locale.Expected:
extract(week from <date>)returns the number of weeks in the year based on the ISO-1868 week-of-week-based-year.Related Issues
Resolves #2477
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.